support 0 max_tokens bucket in local ratelimit

[zirain]

As describe in envoyproxy/gateway#9273, the global rate limit support 0 max token play as always reject, it would be good if we could support same on local ratelimit.

cc @voraci0us @wbpcode

[wbpcode]

Sounds reasonable to me.

[Akshayshahi900]

I'd like to work on this. I've found the validation constraint in token_bucket.proto where max_tokens has gt: 0 — changing to gte: 0 plus adding an always-reject path in the local rate limiter implementation seems to be the fix. Is #45848 still active or can I take this?"

[smishraa30]

hey @zirain could you please assign this issue to me, i would like to work on it!

[zirain]

@smishraa30 I opened #45848 last week, and it's waiting for review.

[zirain]

/closed