From 5a944820de320d51b74361f580b2f55a5c774969 Mon Sep 17 00:00:00 2001 From: "amelia@ivis.ai" Date: Tue, 8 Sep 2026 11:24:00 +0900 Subject: [PATCH 1/3] fix(launch_manager): link -lrt for shm_open/shm_unlink (cherry picked from commit 04f250482e5708e74b885facf77f84b367cddc7c) Signed-off-by: amelia@ivis.ai --- score/launch_manager/src/daemon/BUILD | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/score/launch_manager/src/daemon/BUILD b/score/launch_manager/src/daemon/BUILD index f0f06f2848..8cfc953c29 100644 --- a/score/launch_manager/src/daemon/BUILD +++ b/score/launch_manager/src/daemon/BUILD @@ -16,7 +16,10 @@ cc_binary( name = "launch_manager", srcs = ["src/main.cpp"], linkopts = select({ - "@platforms//os:linux": ["-lpthread"], + "@platforms//os:linux": [ + "-lpthread", + "-lrt", + ], "//conditions:default": [], }), visibility = ["//score/launch_manager:__subpackages__"], From a7501942a9701a8960cf6b5b254d212ea382facb Mon Sep 17 00:00:00 2001 From: hskang Date: Thu, 10 Sep 2026 00:14:43 +0900 Subject: [PATCH 2/3] Update BUILD Address review feedback on eclipse-score#618: glibc 2.34 merged librt and libpthread into libc, but the explicit links stay for older glibc versions. Add a comment in the BUILD file so this is not rediscovered later. Signed-off-by: amelia@ivis.ai --- score/launch_manager/src/daemon/BUILD | 2 ++ 1 file changed, 2 insertions(+) diff --git a/score/launch_manager/src/daemon/BUILD b/score/launch_manager/src/daemon/BUILD index 8cfc953c29..b7e4091488 100644 --- a/score/launch_manager/src/daemon/BUILD +++ b/score/launch_manager/src/daemon/BUILD @@ -16,6 +16,8 @@ cc_binary( name = "launch_manager", srcs = ["src/main.cpp"], linkopts = select({ + # glibc v2.34 integrated libpthread, libdl, libutil, libanl and librt into libc. + # However we keep these links to the old libraries for compatibility with older glibc versions. "@platforms//os:linux": [ "-lpthread", "-lrt", From 925530c7d2aa1ca6122a75850f6bad7eb2f34bf4 Mon Sep 17 00:00:00 2001 From: hskang Date: Thu, 10 Sep 2026 10:11:20 +0900 Subject: [PATCH 3/3] fix(launch_manager): remove trailing whitespace in BUILD The comment about glibc v2.34 folding libpthread/libdl/libutil/ libanl/librt into libc had a trailing space, which failed the Common PR checks formatting check. Signed-off-by: amelia@ivis.ai Signed-off-by: hskang --- score/launch_manager/src/daemon/BUILD | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/score/launch_manager/src/daemon/BUILD b/score/launch_manager/src/daemon/BUILD index b7e4091488..6e2e6615e9 100644 --- a/score/launch_manager/src/daemon/BUILD +++ b/score/launch_manager/src/daemon/BUILD @@ -16,7 +16,7 @@ cc_binary( name = "launch_manager", srcs = ["src/main.cpp"], linkopts = select({ - # glibc v2.34 integrated libpthread, libdl, libutil, libanl and librt into libc. + # glibc v2.34 integrated libpthread, libdl, libutil, libanl and librt into libc. # However we keep these links to the old libraries for compatibility with older glibc versions. "@platforms//os:linux": [ "-lpthread",