|
2609 | 2609 | # The engine's address: the merged list, preset's targets first. |
2610 | 2610 | "the run's ceiling names the target by the merged list rather than the file", |
2611 | 2611 | "internal/recipe/recipe.go", |
2612 | | - "p.add(at(t.ID).of(KeyCount), core.TooManyFilesInRun(planned+files, len(raw.Targets)),", |
2613 | | - "p.add(targetSpot(i, t.ID).of(KeyCount), core.TooManyFilesInRun(planned+files, len(raw.Targets)),", |
| 2612 | + "crossedAt = at(t.ID).of(KeyCount)", |
| 2613 | + "crossedAt = targetSpot(i, t.ID).of(KeyCount)", |
2614 | 2614 | "TestTheTargetThatCrossesTheRunCeilingIsPlacedInTheFile", |
2615 | 2615 | ), |
2616 | 2616 | ( |
2617 | 2617 | "the run's ceiling marks the size of the batch that crossed it rather than its count", |
2618 | 2618 | "internal/recipe/recipe.go", |
2619 | | - "p.add(at(t.ID).of(KeyCount), core.TooManyFilesInRun(planned+files, len(raw.Targets)),", |
2620 | | - "p.add(at(t.ID).of(KeySize), core.TooManyFilesInRun(planned+files, len(raw.Targets)),", |
| 2619 | + "crossedAt = at(t.ID).of(KeyCount)", |
| 2620 | + "crossedAt = at(t.ID).of(KeySize)", |
2621 | 2621 | "TestARefusalAboutTheWholeRunMarksTheBatchThatCausedIt", |
2622 | 2622 | ), |
| 2623 | + ( |
| 2624 | + # Review of #219: the running total where the run crossed is what both |
| 2625 | + # layers said, and ten targets of a million were told two million. |
| 2626 | + "the run's ceiling says the files up to the target that crossed it rather than the whole run's", |
| 2627 | + "internal/recipe/recipe.go", |
| 2628 | + "p.add(crossedAt, core.TooManyFilesInRun(asked, len(raw.Targets)),", |
| 2629 | + "p.add(crossedAt, core.TooManyFilesInRun(int64(planned), len(raw.Targets)),", |
| 2630 | + "TestTheRunCeilingSaysWhatTheWholeRunAsksFor", |
| 2631 | + ), |
| 2632 | + ( |
| 2633 | + "the engine's ceiling says the files up to the target that crossed it rather than the whole run's", |
| 2634 | + "internal/engine/engine.go", |
| 2635 | + "Detail: core.TooManyFilesInRun(filesIn(targets), len(targets)),", |
| 2636 | + "Detail: core.TooManyFilesInRun(int64(totalFiles), len(targets)),", |
| 2637 | + "TestTheEngineCountsTheWholeRunOfTargetsHandedToItDirectly", |
| 2638 | + ), |
2623 | 2639 | ( |
2624 | 2640 | "a target past the run's ceiling has its list built before it is refused", |
2625 | 2641 | "internal/recipe/target.go", |
|
2628 | 2644 | "TestATargetPastTheRunCeilingIsNotBuilt", |
2629 | 2645 | ), |
2630 | 2646 | ( |
| 2647 | + # In core since the review of #219, which named the reader's own copy of |
| 2648 | + # engine.Uniform. Both now take this one. |
2631 | 2649 | "a target's list of sizes is grown one file at a time again", |
2632 | | - "internal/recipe/target.go", |
2633 | | - "\tsizes := make([]int64, count)\n\tfor i := range sizes {\n\t\tsizes[i] = each\n\t}", |
2634 | | - "\tvar sizes []int64\n\tfor range count {\n\t\tsizes = append(sizes, each)\n\t}", |
| 2650 | + "internal/core/size.go", |
| 2651 | + "\tout := make([]int64, n)\n\tfor i := range out {\n\t\tout[i] = bytes\n\t}", |
| 2652 | + "\tvar out []int64\n\tfor range n {\n\t\tout = append(out, bytes)\n\t}", |
2635 | 2653 | "TestATargetsListOfSizesIsReservedAtItsLength", |
2636 | 2654 | ), |
2637 | 2655 | ( |
|
0 commit comments