Native Windows threads

[pmakin]

All windows libraries are cross-compiled via mingw, and because of it all libraries that use threads are dependent on libwinpthread-1.dll. Recompiling them natively using MSVC will remove unnecessary dependency.

So far I'm aware of libcurl. libwinpthread-1.dll is being supplied with libopus, but opus dlls doesn't seem to depend on it.

Not sure how hard it is to add MSVC compilation into the workflow. But maybe relocating libwinpthread-1.dll to curl dir would be an option.

>dumpbin /DEPENDENTS libcurl.dll
Microsoft (R) COFF/PE Dumper Version 14.50.35726.0
Copyright (C) Microsoft Corporation.  All rights reserved.


Dump of file libcurl.dll

File Type: DLL

  Image has the following dependencies:

    ADVAPI32.dll
    bcrypt.dll
    CRYPT32.dll
    KERNEL32.dll
    msvcrt.dll
    libwinpthread-1.dll
    WLDAP32.dll
    WS2_32.dll
    zlib1.dll

>dumpbin /DEPENDENTS libogg.dll
Microsoft (R) COFF/PE Dumper Version 14.50.35726.0
Copyright (C) Microsoft Corporation.  All rights reserved.


Dump of file libogg.dll

File Type: DLL

  Image has the following dependencies:

    KERNEL32.dll
    msvcrt.dll

>dumpbin /DEPENDENTS libopus.dll
Microsoft (R) COFF/PE Dumper Version 14.50.35726.0
Copyright (C) Microsoft Corporation.  All rights reserved.


Dump of file libopus.dll

File Type: DLL

  Image has the following dependencies:

    KERNEL32.dll
    msvcrt.dll

>dumpbin /DEPENDENTS libopusfile.dll
Microsoft (R) COFF/PE Dumper Version 14.50.35726.0
Copyright (C) Microsoft Corporation.  All rights reserved.


Dump of file libopusfile.dll

File Type: DLL

  Image has the following dependencies:

    libogg.dll
    libopus.dll
    KERNEL32.dll
    msvcrt.dll

[def-]

This is difficult since I don't have access to a Windows computer, I can only cross-compile using MinGW

[Robyt3]

Overall, we should build the libraries in a docker container or GitHub CI runner so we can build them natively.

I would also appreciate removing or updating libwinpthread-1.dll because of ddnet/ddnet#10203.

[pmakin]

Overall, we should build the libraries in a docker container or GitHub CI runner so we can build them natively.

I would also appreciate removing or updating libwinpthread-1.dll because of ddnet/ddnet#10203.

Maybe make some kind of sub-repository that will store/fetch and build all the libraries in CI and commit updates here, or if it's possible make such workflow here

[Robyt3]

Maybe make some kind of sub-repository that will store/fetch and build all the libraries in CI and commit updates here, or if it's possible make such workflow here

Yeah, something like that. The Android and Emscripten libraries can already be build in a manually invoked workflow in the CI of the ddnet repository with the https://github.com/ddnet/ddnet/blob/master/scripts/compile_libs/gen_libs.sh script.

Libraries for other platforms are build with https://github.com/ddnet/ddnet-scripts/blob/master/ddnet-lib-update.sh, but it might be more feasible to port all library building to the gen_libs.sh script.

Not sure how to build the libraries for macOS with code signing though. Would have to pass the signing key as secret input to the workflow.

The workflow shouldn't push changes automatically though. The libraries can be build in a workflow and uploaded as an artifact. Then pushed in a PR and reviewed by maintainers.

[pmakin]

Not sure how to build the libraries for macOS with code signing though. Would have to pass the signing key as secret input to the workflow.

Sounds exactly what github secrets are for!

Will be waiting for updates on this 🙏