refactor(HTTP): optimize file path parsing in download() method (#10330)

* refactor(HTTP): optimize download() file path processing and add extreme filename test

* Update tests/system/HTTP/ResponseTest.php

Co-authored-by: Michal Sniatala <michal@sniatala.pl>

* Update tests/system/HTTP/ResponseTest.php

Co-authored-by: Michal Sniatala <michal@sniatala.pl>

* Update tests/system/HTTP/ResponseTest.php

Co-authored-by: Michal Sniatala <michal@sniatala.pl>

* chore(changelog): remove download optimization entry as it is a refactoring

* fix: remove duplicated temporary directory creation in test

---------

Co-authored-by: Michal Sniatala <michal@sniatala.pl>

Author: gr8man

system/HTTP/ResponseTrait.php

@@ -733,20 +733,15 @@ public function download(string $filename = '', $data = '', bool $setMime = fals
             return null;
         }
 
-        $filepath = '';
         if ($data === null) {
-            $filepath = $filename;
-            $filename = explode('/', str_replace(DIRECTORY_SEPARATOR, '/', $filename));
-            $filename = end($filename);
+            $response = new DownloadResponse(basename($filename), $setMime);
+            $response->setFilePath($filename);
+
+            return $response;
         }
 
         $response = new DownloadResponse($filename, $setMime);
-
-        if ($filepath !== '') {
-            $response->setFilePath($filepath);
-        } elseif ($data !== null) {
-            $response->setBinary($data);
-        }
+        $response->setBinary($data);
 
         return $response;
     }

tests/system/HTTP/ResponseTest.php

@@ -494,6 +494,41 @@ public function testGetDownloadResponseByFilePath(): void
         $this->assertSame(file_get_contents(__FILE__), $actualOutput);
     }
 
+    public function testGetDownloadResponseByExtremeFilePath(): void
+    {
+        $response = new Response(new App());
+
+        $tempDir = sys_get_temp_dir() . DIRECTORY_SEPARATOR . 'ci4_test_dir_' . bin2hex(random_bytes(8));
+        $this->assertTrue(mkdir($tempDir));
+        $extremeName = 'my_extreme_file_!@#$%.txt';
+        $extremePath = $tempDir . DIRECTORY_SEPARATOR . $extremeName;
+
+        try {
+            file_put_contents($extremePath, 'extreme data');
+
+            $actual = $response->download($extremePath, null);
+
+            $this->assertInstanceOf(DownloadResponse::class, $actual);
+            $actual->buildHeaders();
+
+            $expectedFilename = $extremeName;
+            $this->assertSame(
+                'attachment; filename="' . addslashes($expectedFilename) . '"; filename*=UTF-8\'\'' . rawurlencode($expectedFilename),
+                $actual->getHeaderLine('Content-Disposition'),
+            );
+
+            ob_start();
+            $actual->sendBody();
+            $actualOutput = ob_get_contents();
+            ob_end_clean();
+
+            $this->assertSame('extreme data', $actualOutput);
+        } finally {
+            @unlink($extremePath);
+            @rmdir($tempDir);
+        }
+    }
+
     public function testVagueDownload(): void
     {
         $response = new Response(new App());