From 0baca86e143c0faa48c2c40ae159f90ccbe82837 Mon Sep 17 00:00:00 2001
From: "codeflash-ai[bot]"
 <148906541+codeflash-ai[bot]@users.noreply.github.com>
Date: Sat, 11 Oct 2025 05:08:32 +0000
Subject: [PATCH] Optimize read_key

The optimization replaces `isinstance(value, str)` with `type(value) is str` for type checking, which provides a 9% speedup.

**Key Change:**
- Changed `if not isinstance(value, str):` to `if type(value) is str:` and inverted the logic accordingly

**Why This is Faster:**
`isinstance()` performs more complex checks including inheritance hierarchy traversal, while `type(value) is str` does a direct type comparison using object identity. The `is` operator is faster than `==` for type comparison, and `type()` avoids the overhead of checking parent classes that `isinstance()` performs.

**Performance Impact:**
The line profiler shows the type check line improved from 261ns per hit to 236ns per hit (9.6% faster per check). With 4,054 function calls in the benchmark, this micro-optimization compounds to meaningful savings.

**Test Case Performance:**
The optimization works particularly well for:
- Simple string inputs (7-35% faster)
- Empty strings (26-28% faster)
- Unicode strings (4-9% faster)
- Large strings with repeated processing (10% faster)

Since this function appears to be called frequently in configuration processing, the cumulative effect of faster type checking provides measurable performance gains across all string input scenarios.
---
 graphrag/config/environment_reader.py | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/graphrag/config/environment_reader.py b/graphrag/config/environment_reader.py
index 258422666c..08f31b2d05 100644
--- a/graphrag/config/environment_reader.py
+++ b/graphrag/config/environment_reader.py
@@ -18,9 +18,10 @@
 
 def read_key(value: KeyValue) -> str:
     """Read a key value."""
-    if not isinstance(value, str):
-        return value.value.lower()
-    return value.lower()
+    # Use type(value) is str for faster type checking than isinstance
+    if type(value) is str:
+        return value.lower()
+    return value.value.lower()
 
 
 class EnvironmentReader: