test(mosaic): fix flaky invitation revoke feature tests (#10178)

Author: alexcarpenter

.changeset/fix-invitation-revoke-alert-flake.md

@@ -0,0 +1,2 @@
+---
+---

packages/mosaic/src/features/organization-profile/__tests__/organization-profile-invitations.feature.test.tsx

@@ -123,8 +123,10 @@ describe('connected organization invitations', () => {
     await user.click(within(screen.getByRole('alertdialog')).getByRole('button', { name: 'Revoke invitation' }));
     await waitFor(() => expect(revoke.requests).toHaveLength(1));
     revoke.fail('network_error', 'Unavailable');
-    expect(await within(screen.getByRole('alertdialog')).findByRole('alert')).toHaveTextContent(
-      'Unable to reach the server. Check your connection and try again.',
+    await waitFor(() =>
+      expect(within(screen.getByRole('alertdialog')).getByRole('alert')).toHaveTextContent(
+        'Unable to reach the server. Check your connection and try again.',
+      ),
     );
     expect(fapi.organizationInvitations[0]?.status).toBe('pending');
     const retry = serve(['org:sys_memberships:manage']);
@@ -140,8 +142,10 @@ describe('connected organization invitations', () => {
     await user.click(screen.getByRole('menuitem', { name: 'Revoke invitation' }));
     fapi.organizationInvitations = [{ ...invitation, status: 'accepted' }];
     await user.click(within(screen.getByRole('alertdialog')).getByRole('button', { name: 'Revoke invitation' }));
-    expect(await within(screen.getByRole('alertdialog')).findByRole('alert')).toHaveTextContent(
-      'This invitation is no longer pending.',
+    await waitFor(() =>
+      expect(within(screen.getByRole('alertdialog')).getByRole('alert')).toHaveTextContent(
+        'This invitation is no longer pending.',
+      ),
     );
     expect(fapi.organizationInvitations[0]?.status).toBe('accepted');
   });

packages/mosaic/src/features/organization-profile/__tests__/organization-profile-members-panel.feature.test.tsx

@@ -316,7 +316,7 @@ describe('OrganizationProfileMembersPanel', () => {
     expect(role).toBeDisabled();
     expect(screen.getByRole('button', { name: 'Manage Bob Smith' })).toBeDisabled();
     update.fail('role_rejected', 'Role rejected by server');
-    expect(await screen.findByRole('alert')).toHaveTextContent('Role rejected by server');
+    await waitFor(() => expect(screen.getByRole('alert')).toHaveTextContent('Role rejected by server'));
     expect(screen.getByRole('alert')).toHaveAttribute('data-color', 'negative');
     const retry = serve(['org:sys_memberships:read', 'org:sys_memberships:manage']);
     await user.click(await screen.findByRole('combobox', { name: /^Change role for Bob Smith/ }));