From d37d42c74d838ffacb59b7694d9a9fae727ca953 Mon Sep 17 00:00:00 2001 From: Mark Hannum Date: Tue, 24 Feb 2026 11:27:19 -0500 Subject: [PATCH] Enable sqllogfill by default Signed-off-by: Mark Hannum --- db/db_tunables.h | 2 +- db/sqllogfill.c | 2 +- tests/tunables.test/t00_all_tunables.expected | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/db/db_tunables.h b/db/db_tunables.h index 6a038dbeb9..75c20ee2c7 100644 --- a/db/db_tunables.h +++ b/db/db_tunables.h @@ -1422,7 +1422,7 @@ REGISTER_TUNABLE("apply_pollms", "Apply-thread poll time before checking queue. " "(Default: 100ms)", TUNABLE_INTEGER, &gbl_apply_thread_pollms, EXPERIMENTAL | INTERNAL, NULL, NULL, NULL, NULL); -REGISTER_TUNABLE("sql_logfill", "Request transaction logs via sql thread. (Default: off)", TUNABLE_BOOLEAN, +REGISTER_TUNABLE("sql_logfill", "Request transaction logs via sql thread. (Default: on)", TUNABLE_BOOLEAN, &gbl_sql_logfill, READONLY, NULL, NULL, NULL, NULL); REGISTER_TUNABLE("sql_logfill_debug", "Enable extended trace for sql logfill thread. (Default: off)", TUNABLE_BOOLEAN, &gbl_debug_sql_logfill, 0, NULL, NULL, NULL, NULL); diff --git a/db/sqllogfill.c b/db/sqllogfill.c index d24b1bae34..bd77627f22 100644 --- a/db/sqllogfill.c +++ b/db/sqllogfill.c @@ -30,7 +30,7 @@ #define TRANLOG_FLAGS_SENTINEL 0x08 /* Return sentinel for missing record */ /* Tunables */ -int gbl_sql_logfill = 0; +int gbl_sql_logfill = 1; int gbl_debug_sql_logfill = 0; int gbl_sql_logfill_stats = 1; int gbl_sql_logfill_dedicated_apply_thread = 0; diff --git a/tests/tunables.test/t00_all_tunables.expected b/tests/tunables.test/t00_all_tunables.expected index e1cde2f794..4082e7f82e 100644 --- a/tests/tunables.test/t00_all_tunables.expected +++ b/tests/tunables.test/t00_all_tunables.expected @@ -968,7 +968,7 @@ (name='sosql_poke_timeout_sec', description='On replicants, when checking on master for transaction status, retry the check after this many seconds.', type='INTEGER', value='60', read_only='N') (name='spfile', description='', type='STRING', value=NULL, read_only='Y') (name='sql_close_sbuf', description='sql_close_sbuf', type='BOOLEAN', value='OFF', read_only='N') -(name='sql_logfill', description='Request transaction logs via sql thread. (Default: off)', type='BOOLEAN', value='OFF', read_only='Y') +(name='sql_logfill', description='Request transaction logs via sql thread. (Default: on)', type='BOOLEAN', value='ON', read_only='Y') (name='sql_logfill_apply_thread', description='Use a dedicated thread to apply sql logfills. (Default: off)', type='BOOLEAN', value='OFF', read_only='Y') (name='sql_logfill_debug', description='Enable extended trace for sql logfill thread. (Default: off)', type='BOOLEAN', value='OFF', read_only='N') (name='sql_logfill_lookahead_records', description='Max lookahead records cached for dedicated apply thread. (Default: 10000)', type='INTEGER', value='10000', read_only='Y')