You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A recent Explanation change I done, #16229 has led me to some more explanation improvements.
Bit of a WIP issues, I'll edit this comment when I get some more time.
I am thinking of looking at the following:
Testing gap in testExplainFailingOptionalClauses. It only asserts on the failingOptionals list, not the main subs list. Adding a subs.clear() into BooleanWeight doesn't fail any tests.
CheckHits.checkNoMatchExplanations is shallow. It only checks the root explanation's isMatch() == false and never looks at its sub-details. Nested non-match sub-explanations are never structurally verified.
Description
A recent Explanation change I done, #16229 has led me to some more explanation improvements.
Bit of a WIP issues, I'll edit this comment when I get some more time.
I am thinking of looking at the following:
subs.clear()into BooleanWeight doesn't fail any tests.// :TODO: we really need more crazy complex cases.