Skip to content

Commit a979e55

Browse files
committed
Use pyiceberg.__version__ for PuffinWriter created-by default
Switch from importlib.metadata.version('pyiceberg') to the exported __version__ to match the existing pattern in cli/console.py and avoid PackageNotFoundError when pyiceberg is not pip-installed. Co-authored-by: Isaac
1 parent a6d2f31 commit a979e55

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

pyiceberg/table/puffin.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
# KIND, either express or implied. See the License for the
1515
# specific language governing permissions and limitations
1616
# under the License.
17-
import importlib.metadata
1817
import io
1918
import math
2019
import zlib
@@ -24,6 +23,7 @@
2423
from pydantic import Field
2524
from pyroaring import BitMap, FrozenBitMap
2625

26+
from pyiceberg import __version__
2727
from pyiceberg.io import OutputFile
2828
from pyiceberg.typedef import IcebergBaseModel
2929

@@ -167,7 +167,7 @@ def __init__(self, output_file: OutputFile, created_by: str | None = None) -> No
167167
self._blobs = []
168168
self._blob_payloads = []
169169
self._created_by = (
170-
created_by if created_by is not None else f"PyIceberg version {importlib.metadata.version('pyiceberg')}"
170+
created_by if created_by is not None else f"PyIceberg version {__version__}"
171171
)
172172

173173
def set_blob(

tests/table/test_puffin.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,14 @@
1414
# KIND, either express or implied. See the License for the
1515
# specific language governing permissions and limitations
1616
# under the License.
17-
import importlib.metadata
1817
import zlib
1918
from os import path
2019
from pathlib import Path
2120

2221
import pytest
2322
from pyroaring import BitMap
2423

24+
from pyiceberg import __version__
2525
from pyiceberg.io.pyarrow import PyArrowFileIO
2626
from pyiceberg.table.puffin import (
2727
DELETION_VECTOR_MAGIC,
@@ -202,7 +202,7 @@ def test_puffin_writer_default_created_by(tmp_path: Path) -> None:
202202
writer.finish()
203203

204204
reader = PuffinFile(puffin_path.read_bytes())
205-
assert reader.footer.properties["created-by"] == f"PyIceberg version {importlib.metadata.version('pyiceberg')}"
205+
assert reader.footer.properties["created-by"] == f"PyIceberg version {__version__}"
206206

207207

208208
def test_set_blob_rejects_negative_positions(tmp_path: Path) -> None:

0 commit comments

Comments
 (0)