Merged
Conversation
nuno-faria
commented
Mar 1, 2026
26 tasks
Member
|
Nice work! There's quite a bit to review, but I plan on getting to it soon. |
Member
|
Related: #1407 |
timsaucer
approved these changes
Mar 6, 2026
Member
timsaucer
left a comment
timsaucer
left a comment
There was a problem hiding this comment.
Thank you so much for putting this together, and especially with the detailed sources for the diffs!
| datetime(2020, 7, 1, tzinfo=DEFAULT_TZ), | ||
| ], | ||
| type=pa.timestamp("ns", tz=DEFAULT_TZ), | ||
| type=pa.timestamp("us", tz=DEFAULT_TZ), |
Member
There was a problem hiding this comment.
Ok, I think this is from apache/datafusion#19640 where it is now passing through the original data type from the input instead of changing it to nanoseconds. I think this is appropriate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A.
Rationale for this change
Keep in sync with the next major version of DataFusion.
What changes are included in this PR?
This PR is quite large, but most changes are related to the new version of PyO3.
datafusion,pyo3, andarrow(migrated the respective code as well).DataFusion 53.0.0section in the upgrade guide (sincePyCapsuleMethods::referenceis now deprecated).Are there any user-facing changes?
Yes, the behavior has changed in a few tests (the review comments below contain more info).