Don't allow additon of template settings when the template is in Not-Ready state

[kiranchavala]

problem

Don't allow addition of template settings when the template is in Not-Ready state

versions

ACS 4.22

The steps to reproduce the bug

1. Login to cloudstack with a admin role

Navigate Images > Template > Register a template > enable “Read Instance settings from OVA”

2. When the template is getting downloaded , its in Not ready state

3. Navigate to template settings and try to add Template settings

4. The template settings gets added

What to do about it?

CloudStack should thrown exception saying that its unable to add settings when the template is in not-ready state or Settings are read directly from the template

[DaanHoogland]

How harmful is it when settings get added?
Can these be cleaned after the template is ready (and should they)?

also, is this a new issue/regression @kiranchavala ?