I verified this with my own azure storage account, it works great. Thanks for adding this!
I think there are a few follow-ups could make the delegation-key cache more flexible and robust:
- Make
DELEGATION_KEY_VALIDITY optionally configurable so users can limit how long reusable keys remain valid. This setting should never shorten a key below the requested SAS lifetime.
- Remove the fixed
DELEGATION_KEY_MIN_TTL. Azure returns the key’s actual SignedExpiry, so cache it and reuse the key only when SignedExpiry is later than the requested SAS expiry. Otherwise, fetch a new key.
- Treat Azure’s returned
SignedStart and SignedExpiry as authoritative. Return a clear error if they are malformed or do not cover the full SAS lifetime.
Originally posted by @kevinjqliu in #781 (comment)
I verified this with my own azure storage account, it works great. Thanks for adding this!
I think there are a few follow-ups could make the delegation-key cache more flexible and robust:
DELEGATION_KEY_VALIDITYoptionally configurable so users can limit how long reusable keys remain valid. This setting should never shorten a key below the requested SAS lifetime.DELEGATION_KEY_MIN_TTL. Azure returns the key’s actualSignedExpiry, so cache it and reuse the key only whenSignedExpiryis later than the requested SAS expiry. Otherwise, fetch a new key.SignedStartandSignedExpiryas authoritative. Return a clear error if they are malformed or do not cover the full SAS lifetime.Originally posted by @kevinjqliu in #781 (comment)