[Bug]: Changing input monitoring mode during recording stops the recording

[hgroenenboom]

Detailed steps on how to reproduce the bug

• Start a recording
• Change the input monitoring mode
• The recording stops automatically

What is the expected behaviour?

Changing the input monitoring mode does not stop the recording, only the input monitoring for the device is changed.

I found this code snippet:

        // This logic rebuilds the audio graph if the monitor state changes as it's a static node-type in the graph
        if (destinationsChanged || (! wasRecording && wasLivePlayActive != isLivePlayActive))
            restartPlayback = true;

        wasLivePlayActive = isLivePlayActive;

Would it be possible to avoid a graph rebuild when input monitoring is changed?

Unit test to reproduce the error?

Operating systems

Windows

What versions of the operating systems?

Windows 11

Architectures

x86_64

Stacktrace

Plug-in formats (if applicable)

No response

Plug-in host applications (DAWs) (if applicable)

No response

Testing on the develop branch

The bug is present on the develop branch

Code of Conduct

• I agree to follow the Code of Conduct