Skip to content

🔧 Replaced jsoncpp with Poco::JSON#141

Open
AnotherFoxGuy wants to merge 1 commit into
RigsOfRods:masterfrom
AnotherFoxGuy:jsoncpp-gone
Open

🔧 Replaced jsoncpp with Poco::JSON#141
AnotherFoxGuy wants to merge 1 commit into
RigsOfRods:masterfrom
AnotherFoxGuy:jsoncpp-gone

Conversation

@AnotherFoxGuy

Copy link
Copy Markdown
Member

Part of #139

@ohlidalp ohlidalp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Undo the SendMessage() -> SWSendMessage() find&replace please. I see no reason for that.
  • Make the JsonToString() macro a function - I see no reason to make it a macro.

@AnotherFoxGuy

Copy link
Copy Markdown
Member Author

Undo the SendMessage() -> SWSendMessage() find&replace please. I see no reason for that.

The issue with that is that the SendMessage() function conflicts with the SendMessage() from Microsoft
https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-sendmessage

@AnotherFoxGuy AnotherFoxGuy force-pushed the jsoncpp-gone branch 2 times, most recently from 428b367 to 2a92010 Compare January 8, 2025 16:14
@AnotherFoxGuy AnotherFoxGuy requested a review from ohlidalp January 8, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants