Test Scan Settings Failure

[dxmaxwell]

A stand alone test fails (even before update to Python3):

devuser@gascell09:~/gascellioc/iocBoot/iocGasCellScan/PyScanClient/Test$ PYTHONPATH=".." python ./test_scan_settings.py
DeviceSettings('SomeRandomDevice', completion=False, readback='SomeRandomDevice', timeout=0, tolerance=None, comparison='>=', parallel=False)
DeviceSettings('My:Lakeshore1', completion=True, readback=None, timeout=300, tolerance=10, comparison='>=', parallel=False)
DeviceSettings('Your:Lakeshore1', completion=False, readback='Your:Lakeshore1', timeout=0, tolerance=None, comparison='>=', parallel=False)
DeviceSettings('My:Motor:47', completion=True, readback='My:Motor:47.RBV', timeout=100, tolerance=None, comparison='>=', parallel=False)
DeviceSettings('SomeCounter', completion=False, readback='SomeCounter', timeout=0, tolerance=None, comparison='>=', parallel=False)
DeviceSettings('PerpetualCounter', completion=False, readback=None, timeout=0, tolerance=None, comparison='increase by', parallel=False)
.DeviceSettings('device', completion=False, readback=None, timeout=0, tolerance=None, comparison='>=', parallel=False)
DeviceSettings('device', completion=False, readback='device', timeout=0, tolerance=None, comparison='>=', parallel=False)
DeviceSettings('device', completion=False, readback='other', timeout=0, tolerance=None, comparison='>=', parallel=False)
.My:Lakeshore1 -> DeviceSettings('My:Lakeshore1', completion=True, readback=None, timeout=300, tolerance=10, comparison='>=', parallel=False)
-c My:Lakeshore1 -> DeviceSettings('My:Lakeshore1', completion=False, readback=None, timeout=300, tolerance=10, comparison='>=', parallel=False)
+p-c+r My:Lakeshore1 -> DeviceSettings('My:Lakeshore1', completion=False, readback='My:Lakeshore1', timeout=300, tolerance=10, comparison='>=', parallel=True)
+pr My:Lakeshore1 -> DeviceSettings('My:Lakeshore1', completion=True, readback='My:Lakeshore1', timeout=300, tolerance=10, comparison='>=', parallel=True)
+p-cr My:Motor:47 -> DeviceSettings('My:Motor:47', completion=False, readback=None, timeout=100, tolerance=None, comparison='>=', parallel=True)
..F.
======================================================================
FAIL: testSettingsBasedSet (__main__.DeviceSettingsTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./test_scan_settings.py", line 147, in testSettingsBasedSet
    self.assertEquals(str(cmd), "Set('My:Motor1', 42, completion=True, readback='My:Motor1.RBV', timeout=100)")
AssertionError: "Set('My:Motor1', 42, completion=True, timeout=100, readback='My:Motor1.RBV', tolerance=0.100000)" != "Set('My:Motor1', 42, completion=True, readback='My:Motor1.RBV', timeout=100)"

----------------------------------------------------------------------
Ran 6 tests in 0.001s

FAILED (failures=1)

To me it looks like the result is correct, but the test needs to be updated to reflect some changes made a few months to the Set command representation (Commit: be2542d).

[kasemir]

Thanks, I think it's now fixed.