Skip to content

feat(recur): add skip property accessor to vRecur (#1851, RFC 7529) - #2179

Open
RishabhIIITD wants to merge 1 commit into
PyCalendar:mainfrom
RishabhIIITD:feat/recur-skip-property
Open

RishabhIIITD wants to merge 1 commit into
PyCalendar:mainfrom
RishabhIIITD:feat/recur-skip-property

Conversation

@RishabhIIITD

Copy link
Copy Markdown

Summary of Changes

Addresses #1851 (RFC 7529).

This PR implements the property accessor, setter, and deleter for the SKIP recurrence rule part on vRecur, defined in RFC 7529 Section 3.2.

Implementation Checklist

  • return type is None or vSkip as specified in vRecur.types
  • setting to None deletes the value
  • del deletes the value
  • if multiple values are given, the first one is returned
  • if an empty list is in there, None is returned
  • docstring with example values: >>> vRecur("FREQ=YEARLY;RSCALE=CHINESE;SKIP=FORWARD").skip
  • docstring summarizes what this property is about
  • validates allowed values (OMIT, BACKWARD, FORWARD), raising InvalidCalendar on invalid skip values and TypeError on incorrect types
  • 18 unit tests in src/icalendar/tests/prop/recur/test_skip.py covering parsing, normalization, assignment, roundtrip, and error handling

…FC 7529)

- Add skip property getter, setter, and deleter to vRecur
- Return vSkip instance or None when absent
- Parse case-insensitively and validate against OMIT, BACKWARD, FORWARD
- Raise InvalidCalendar on invalid skip value and TypeError on wrong types
- Add 18 comprehensive unit tests covering parsing, roundtrip, mutations, and error handling
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the pull request, @RishabhIIITD! A maintainer will review it shortly.

@angatha

angatha commented Nov 21, 2026

Copy link
Copy Markdown
Collaborator

Thank you for the contribution. Please follow our contribution guide which was linked in the PR template that you did not used.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants