Repository navigation
feat(recur): add skip property accessor to vRecur (#1851, RFC 7529) - #2179
Open
RishabhIIITD wants to merge 1 commit into
Open
RishabhIIITD wants to merge 1 commit into
RishabhIIITD wants to merge 1 commit into
Conversation
…FC 7529) - Add skip property getter, setter, and deleter to vRecur - Return vSkip instance or None when absent - Parse case-insensitively and validate against OMIT, BACKWARD, FORWARD - Raise InvalidCalendar on invalid skip value and TypeError on wrong types - Add 18 comprehensive unit tests covering parsing, roundtrip, mutations, and error handling
RishabhIIITD
requested review from
angatha,
niccokunzmann and
stevepiercy
as code owners
November 20, 2026 04:59
Contributor
|
Thanks for the pull request, @RishabhIIITD! A maintainer will review it shortly. |
Collaborator
|
Thank you for the contribution. Please follow our contribution guide which was linked in the PR template that you did not used. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Addresses #1851 (RFC 7529).
This PR implements the property accessor, setter, and deleter for the
SKIPrecurrence rule part onvRecur, defined in RFC 7529 Section 3.2.Implementation Checklist
NoneorvSkipas specified invRecur.typesNonedeletes the valuedeldeletes the valueNoneis returned>>> vRecur("FREQ=YEARLY;RSCALE=CHINESE;SKIP=FORWARD").skipOMIT,BACKWARD,FORWARD), raisingInvalidCalendaron invalid skip values andTypeErroron incorrect typessrc/icalendar/tests/prop/recur/test_skip.pycovering parsing, normalization, assignment, roundtrip, and error handling