Add sinus and cosinus for SD59x18#230
Open
Amxx wants to merge 5 commits into
Open
Conversation
Contributor
Author
|
Note: https://github.com/mds1/solidity-trigonometry/blob/main/src/Trigonometry.sol should be considered. I don't understand the underlying logic, but if translated to signed integers, it might be cheaper / more accurate ? |
Owner
|
Hi @Amxx, thank you for your PR. I just wanted to say that it might take a few weeks (or more) until I'm able to review this. The |
Contributor
Author
|
@PaulRBerg Sure, not rush. There may be otehr implementations that deserves exploring anyway. |
PaulRBerg
force-pushed
the
main
branch
2 times, most recently
from
7aff5a3 to
b8583d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(work in progress)