Skip to content

CONTRIBUTING.md: Protocol/Transport section still says peer and dispute chat use NIP-59 gift wrap #338

Description

@Matobi98

CONTRIBUTING.md, under "Protocol / Transport Changes", currently reads:

Transport v2 — daemon messages (new-order, take, release, cancel, dispute, rate, invoice, restore) use NIP-44 / signed Kind 14; peer and dispute chat use NIP-59 gift wrap (Kind 1059).

This is outdated. NIP-59 gift wrap was dropped from both peer and dispute chat in #246/#254 — the client no longer reads or writes Kind 1059 in either direction. Chat now rides a custom Kind-14 envelope instead (see rust/src/api/messages.rs and rust/src/api/disputes.rs).

Proposed fix: update the Transport v2 bullet to describe the Kind-14 chat envelope instead of gift wrap, matching the corrected README language.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions