Skip to content

negative signal values unaccounted for #389

Description

@drbergman

Negative signal values have unexpected effects on rules depending on the hill power:

  • even ==> sign is effectively ignored ==> treat extremely low values (<0) as their positive opposites
  • odd ==> introduces negatives into the multivariate hill function inputs, possibly causing negative outputs (with unintended consequences) or even a divide-by-zero error
  • non-integer ==> produce nan results

Note: Non-integer hill powers are allowed by PhysiCell (though not Studio) as the parser is std::atof and not std::atoi

For the most part, this is ok since most signals are non-negative. However, intracellular concentrations can go negative and often do. We could either address this when getting the intracellular signal (max that return with 0) or set a check at rule evaluation, incurring extra cost across all rules/signals.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions