fix kornia pyramid padding import for compatibility with v0.8.3+#506
Open
DevNullInc wants to merge 1 commit into
Open
fix kornia pyramid padding import for compatibility with v0.8.3+#506DevNullInc wants to merge 1 commit into
DevNullInc wants to merge 1 commit into
Conversation
The latest updates to the kornia library totally broke this file because they removed the pad function from the pyramid submodule. Because of that, it was throwing a fatal import error and causing the entire extension to fail silently on launch whenever ComfyUI booted up. This patch fixes the crash by pulling pad out of the kornia list and just mapping it directly to the torch functional pad that is already loaded in the environment. It keeps everything working exactly the same way but actually lets the node pack load properly on newer setups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest updates to the kornia library totally broke this file because they removed the pad function from the pyramid submodule. Because of that, it was throwing a fatal import error and causing the entire extension to fail silently on launch whenever ComfyUI booted up. This patch fixes the crash by pulling pad out of the kornia list and just mapping it directly to the torch functional pad that is already loaded in the environment. It keeps everything working exactly the same way but actually lets the node pack load properly on newer setups.