Skip to content

conformance: the kits have no negative test, so gutting a check ships green #44

Description

@JumpTechCode

Adversarial review mutated VerifyRun and Verify and every mutation survived: removing the empty-ID check, the empty-instruction refusal check, the beyond-guarantees refusal check, and accepting TierWire all leave go test ./internal/adapter/conformance/... passing.

TestBeyondNamesEveryUndeclaredCondition exercises beyond and port.Refuse directly and never routes through VerifyRun, so a broken kit ships green and then blesses every non-conforming adapter that adopts it. The capture side has the same hole — gutting verify.go's ID check also survives — so this is a repo-wide pattern rather than a regression from the run seam. What is new is ADR-0008 and a test comment claiming the kit has teeth.

Fix: a deliberately non-conforming adapter of each kind (empty ID, TierWire, Sit returning nil for an empty assignment, Discover ignoring Native) run through the kit with a captured *testing.T, asserting it fails.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions