Repository navigation
Fix inference losses in the AL, finish, and PowerMean solvers - #101
Merged
Merged
Conversation
`_difference_solve!` returns `Vector{T}` from both branches; its
CHOLMOD branch used to return `Vector{Float64}`, which made the
weighted-solve closure of `_abslog2_auglag` return a union for wide
element types and widened the whole multiplier loop to `Any`.
Three closures captured variables that are also assigned elsewhere in
their function and so were boxed: the Hessian product of the PowerMean
Newton step (a per-edge dynamic dispatch), the dual-feasibility check
of the active-set finish, and the diagonal-position comprehension of
`_powermean_linsolve`. Each now captures a binding made once.
`_check_representable` specializes on its predicate arguments.
Assisted-by: Claude Fable 5.1 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 25 25
Lines 7540 7542 +2
=======================================
+ Hits 7415 7417 +2
Misses 125 125 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_difference_solve!returnsVector{T}from both branches; its CHOLMOD branch used to returnVector{Float64}, which made the weighted-solve closure of_abslog2_auglagreturn a union for wide element types and widened the whole multiplier loop toAny.Three closures captured variables that are also assigned elsewhere in their function and so were boxed: the Hessian product of the PowerMean Newton step (a per-edge dynamic dispatch), the dual-feasibility check of the active-set finish, and the diagonal-position comprehension of
_powermean_linsolve. Each now captures a binding made once._check_representablespecializes on its predicate arguments.Assisted-by: Claude Fable 5.1 noreply@anthropic.com