From 6310192975ae7e964fb423fe8d346420cbbd0a74 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Mon, 12 Dec 2022 13:53:00 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- setup.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 3f59a96..03c30ff 100644 --- a/setup.py +++ b/setup.py @@ -57,7 +57,26 @@ def rename_dir(files, name): def untar(path, strip=None): with tarfile.open(path) as tar: - tar.extractall("vendor", rename_dir(tar.getmembers(), strip)) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, "vendor", rename_dir(tar.getmembers(),strip)) def get_version(): version_regex = re.compile(r'^__version__\s*=\s*[\'"]([^\'"]*)[\'"]', re.MULTILINE)