Support for delete all?

[thomasms]

Hi,

Thanks for the recent updates to the documentation, this is a useful utility!

I cannot find anything regarding a deleteAll API in the documentation and looking in the code it seems it is not supported:

    @Override
    public void deleteAll(Iterable<? extends XmlChannel> entities) {
        throw new UnsupportedOperationException("Delete All is not supported.");
    }

    @Override
    public void deleteAll() {
        throw new UnsupportedOperationException("Delete All is not supported.");
    }

Is there any reason why this is not supported? Are there plans to implement this in the future?

The reason I ask is that I would find it useful in a few use cases. Iterating over all channel names to delete each one individually is going to be painful for 1000+ PVs.

[shroffk]

Hello, there is a general desire to make delete data a task one which requires care and consideration.

Instead of exposing a delete all functionality to eveyone... if the situation arises that all channels need to be deleted then someone can delete the elastic index and recreate it (using the elastic rest api)

[iTerminate]

@shroffk I would also find it useful to have an API that lets me provide a list of Channels for deletion. This would not be functionality that lets your clear all the channels but ones that have been specified within the API call. Since the functionality is scriptable, it doesn't matter if the functionality is exposed or not. It just takes a bit longer to clear all the channels from the database with current functionality.

My use case is such that I have a script that updates pv records for various IOCs, I remove all Channels that belong to specific IOC before I add the new ones into ChannelFinder, this removes the possibility of keeping Channels that no longer exist for the specific IOC. After doing some performance testing with the latest version I noticed that the create function with a list of channels is very fast but my clearing of channels is still slow since I have to do it one by one. If you think its best not to expose this functionality, I can alternatively fetch a list of pvs for the specific IOC and compare in my script to see if any need to be removed, maybe it is a better approach? I see that the create function also deletes all existing channels before adding new ones so I don't have to worry about some stagnant properties/tags?

[shroffk]

@iTerminate I have added a batch delete #217, this should significantly improve the delete/cleanup steps

For delete all, the preferred way would still be to simply delete the index the restart.

[iTerminate]

@shroffk Thank you! I added an issue to take advantage of this new function!