Skip to content

Move the vesting choices onto the instrument config #167

Description

@lmcorbalan

User story / Problem statement

Currently every choice that moves value takes an AppTransferContext of AmuletRules plus an open mining round, and every template and choice carries an Amulet prefix the vesting package does not use.

Expected outcome

The four value-moving choices take a single configCid fetched from the registry, and the builders name the vesting package's own templates and choices.

Acceptance criteria

  • commands.ts builds VestingFactory_CreateVesting, VestingProposal_Accept, VestingContract_Withdraw, VestingContract_Cancel and VestedClaim_Withdraw
  • buildTapCommand builds InstrumentConfig_Tap
  • amuletCids is tokenCids and ctx is configCid
  • Every filter names #vesting:Vesting:<template>
  • Accept, withdraw, cancel and residual claim each disclose the config
  • pnpm typecheck passes at this commit

Technical notes

buildSplitCommand and splitOff deliberately stay: transferContext.ts survives until task 3, and deleting either here breaks the typecheck the pre-push hook runs.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or requestpriority: highMust be addressed in current sprint

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions