Repository navigation
feat: rename batching delay to request_delay - #42
Merged
Merged
Conversation
Validate delay values and emit the KEGG rate-limit warning from one helper. Add an iterator-based batch runner that sleeps only between requests and accepts an injectable sleep callback for deterministic tests.
Migrate conversion, retrieval, link, and list batching to the shared iterator helper. Keep timeout as a deprecated alias, avoid final sleeps, and update the Julia benchmark to use the accurately named keyword.
Exercise the deprecated timeout alias, conflicting and invalid delay values, lazy partition URLs, and per-wrapper sleep counts with injected request and sleep callbacks.
Document request_delay, the deprecated timeout alias, validation failures, and between-request timing. Update the README example, stale conversion names, benchmark instructions, and rate-limit warning wording.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
cvigilv
force-pushed
the
cv/fix30-request-delay
branch
from
September 15, 2026 16:23
14f8fa8 to
ffa769c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
request_delayto batchedkegg_conv,kegg_get,kegg_link, andkegg_listcallstimeoutas a deprecated compatibility alias with conflict and value validationValidation
julia --project -e 'using Pkg; Pkg.test()'julia --project=docs docs/make.jlsrc/,test/, anddocs/Fixes #30.