Skip to content

Add Tables.jl result contract - #37

Closed
cvigilv wants to merge 2 commits into
mainfrom
cv/fix26
Closed

Add Tables.jl result contract#37
cvigilv wants to merge 2 commits into
mainfrom
cv/fix26

Conversation

@cvigilv

@cvigilv cvigilv commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Closes #26.

Summary

  • add the exported, immutable KeggTable result type and its Tables.jl column-access interface
  • standardize tabular responses on named String columns, including known schemas for empty and batched results
  • report conversion and link columns as source_id then target_id, matching KEGG response order
  • keep .data and .colnames as deprecated compatibility properties
  • document direct DataFrame(result) conversion and named-column access

Tests

  • julia +1.10 --project -e 'using Pkg; Pkg.test()'
  • julia +release --project -e 'using Pkg; Pkg.test()'
  • julia +release --project=docs docs/make.jl

@codecov

codecov Bot commented Sep 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.91667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/List.jl 66.66% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/Conv.jl 100.00% <100.00%> (ø)
src/Ddi.jl 100.00% <ø> (ø)
src/Find.jl 90.00% <100.00%> (ø)
src/KEGGAPI.jl 100.00% <ø> (ø)
src/Link.jl 96.15% <100.00%> (ø)
src/Parsers.jl 100.00% <100.00%> (+41.79%) ⬆️
src/Structures.jl 100.00% <100.00%> (+33.33%) ⬆️
src/List.jl 30.43% <66.66%> (-18.06%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cvigilv
feat!: move to Tables.jl for results
6712d8c 
Unify tabular KEGG responses under an exported KeggTable type, preserve deprecated compatibility properties, and document direct Tables.jl and DataFrames use.

Fixes #26
@cvigilv
fix: standardize tabular result rows
1b22163 
Keep the existing native result containers and define data as a vector
of rows. Add collection access and parse complete list responses before
splitting lines.

Addresses #24.
Fixes #26.
Fixes #28.
@cvigilv cvigilv mentioned this pull request Sep 15, 2026
Closed
@cvigilv

cvigilv commented Sep 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Closing in order to not introduce more breaking changes

@cvigilv cvigilv closed this Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Define a consistent contract for tabular results

1 participant

@cvigilv