Skip to content

[TEST] add more test coverage to native unrwap property tests#428

Open
meilu-git wants to merge 5 commits into
mainfrom
meilu/native_azihsm_ecc_keyunwrap_property
Open

[TEST] add more test coverage to native unrwap property tests#428
meilu-git wants to merge 5 commits into
mainfrom
meilu/native_azihsm_ecc_keyunwrap_property

Conversation

@meilu-git

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds expanded GoogleTest coverage for azihsm_key_unwrap_pair ECC key-pair unwrap property validation in the C++ integration tests.

Changes:

  • Introduces a large set of new negative tests around malformed/invalid ECC unwrap key properties (curve, session, usage flags, lengths, duplicates).
  • Adds additional scenarios using a real wrapped ECC blob to validate failure modes that require successful unwrap/decode setup.

Comment thread api/tests/cpp/algo/ecc/unwrap_property_tests.cpp Outdated
Comment thread api/tests/cpp/algo/ecc/unwrap_property_tests.cpp Outdated
Comment thread api/tests/cpp/algo/ecc/unwrap_property_tests.cpp Outdated
Comment thread api/tests/cpp/algo/ecc/unwrap_property_tests.cpp Outdated
@meilu-git meilu-git force-pushed the meilu/native_azihsm_ecc_keyunwrap_property branch from 6a4760d to 1ee2ef6 Compare June 5, 2026 19:03
Copilot AI review requested due to automatic review settings June 5, 2026 21:10
@meilu-git meilu-git force-pushed the meilu/native_azihsm_ecc_keyunwrap_property branch from 1ee2ef6 to 6622db8 Compare June 5, 2026 21:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 7 comments.

Comment thread api/tests/cpp/algo/ecc/unwrap_property_tests.cpp Outdated
Comment thread api/tests/cpp/algo/ecc/unwrap_property_tests.cpp Outdated
Comment thread api/tests/cpp/algo/ecc/unwrap_property_tests.cpp Outdated
Comment thread api/tests/cpp/algo/ecc/unwrap_property_tests.cpp Outdated
Comment thread api/tests/cpp/algo/ecc/unwrap_property_tests.cpp Outdated
Comment thread api/tests/cpp/algo/ecc/unwrap_property_tests.cpp Outdated
Comment thread api/tests/cpp/algo/ecc/unwrap_property_tests.cpp Outdated
@meilu-git meilu-git force-pushed the meilu/native_azihsm_ecc_keyunwrap_property branch from 6622db8 to ad7716a Compare June 9, 2026 00:15
Copilot AI review requested due to automatic review settings June 9, 2026 00:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants