Commit e49cdd6
committed
Correct the public docs the dependency drop left stale
Four review findings, all valid, all mine.
Codex P2 -- src/lib.rs and README.md still told downstream users that enabling
`std` pulls the external blake3 crate and that the hpc modules import it
directly. That was true before this branch and false after it, which is worse
than saying nothing: it is wrong feature and dependency information on the
crate's two most-read public surfaces. Both rewritten to state that BLAKE3 is
in-tree and that blake3 / constant_time_eq / arrayref / arrayvec are absent
from the dependency graph at every feature combination.
CodeRabbit -- the Cargo.toml comment I wrote in the first commit claimed the
in-tree module is "built on ndarray::simd::U32x16 (it is a ChaCha-derived u32
ARX kernel)". That is simply false. src/hpc/blake3.rs says so in its own
header: "a portable-only (no SIMD, no unsafe) transcription" of the reference
implementation. Its only `simd` reference is crate::simd_ops::array_chunks, a
slicing helper. Corrected, and the cycle paragraph now says dropping the dep
enables a FUTURE ndarray-backed implementation and the AdaWorldAPI/BLAKE3
fork -- not this module, which is portable.
CodeRabbit -- the knowledge doc said "14 call sites" in one place and the swap
record said 15. Both were right about different things: 14 calls plus one type
position (merkle_tree::truncate_hash's `&blake3::Hash` parameter). Made
explicit rather than reconciled to one number, since the distinction is the
reason the counts differed.
Verified: cargo build --features std clean, fmt clean, and no "pulls blake3"
claim survives anywhere in README.md, src/lib.rs or Cargo.toml.
Claude-Session: https://claude.ai/code/session_01VdfbkUCBbtZhy3yjSfCDHp1 parent 9b2dba8 commit e49cdd6
4 files changed
Lines changed: 56 additions & 34 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
42 | 48 | | |
43 | 49 | | |
44 | 50 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
157 | 157 | | |
158 | 158 | | |
159 | 159 | | |
160 | | - | |
161 | | - | |
162 | | - | |
163 | | - | |
164 | | - | |
165 | | - | |
166 | | - | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
167 | 171 | | |
168 | 172 | | |
169 | 173 | | |
170 | 174 | | |
171 | | - | |
| 175 | + | |
| 176 | + | |
172 | 177 | | |
173 | 178 | | |
174 | 179 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
210 | 210 | | |
211 | 211 | | |
212 | 212 | | |
213 | | - | |
214 | | - | |
215 | | - | |
216 | | - | |
217 | | - | |
218 | | - | |
219 | | - | |
220 | | - | |
221 | | - | |
222 | | - | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
223 | 229 | | |
224 | 230 | | |
225 | | - | |
226 | | - | |
| 231 | + | |
| 232 | + | |
227 | 233 | | |
228 | 234 | | |
229 | 235 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
485 | 485 | | |
486 | 486 | | |
487 | 487 | | |
488 | | - | |
489 | | - | |
490 | | - | |
491 | | - | |
492 | | - | |
493 | | - | |
494 | | - | |
495 | | - | |
496 | | - | |
497 | | - | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
498 | 503 | | |
499 | 504 | | |
500 | 505 | | |
| |||
0 commit comments